[mkgmap-dev] [Patch] unpaved roads

Thu Feb 9 08:41:38 GMT 2017

OK, here is v3 of the patch based on v1.  Changes:
- also treat surface=paving_stones:30 as paved
- treat highway=via_ferrata as unpaved
- don't interpret smoothness=bad as unpaved

Add spead penalty for roads with very_bad or worser smoothness if they are not flagged as unpaved
highway=* & mkgmap:unpaved!=1 & smoothness ~ '.*(bad|horrible|impassable)'  { add mkgmap:road-speed = '-2' }

I still don't like this version. It sets mkgmap:unpaved=1 for highways which are explicitely mapped as paved, e.g.
http://www.openstreetmap.org/way/150436049
which matches
highway=tertiary & surface=paved & smoothness=very_bad
or
http://www.openstreetmap.org/way/38245394

There are quite a lot of major highways with a combination of paved surface and ugly smoothness.
I think the smoothness tag should only be used to add a road speed penalty.

Gerd

________________________________________
Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag von lig fietser <ligfietser at hotmail.com>
Gesendet: Donnerstag, 9. Februar 2017 09:05:00
An: Development list for mkgmap
Betreff: Re: [mkgmap-dev] [Patch] unpaved roads

Yes, thats what I intended. Thanks for correcting this Gerd.

________________________________
Van: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> namens Gerd Petermann <GPetermann_muenchen at hotmail.com>
Verzonden: woensdag 8 februari 2017 23:10:41
Aan: Development list for mkgmap
Onderwerp: Re: [mkgmap-dev] [Patch] unpaved roads

The thread suggest different changes. The last one is this:
highway=* & mkgmap:unpaved=0 & smoothness ~ '.*(bad|horrible|impassable)'  { add mkgmap:road-speed = '-2' }

I think this will not work as there is no rule to set mkgmap:unpaved=0.
Did you mean mkgmap:unpaved!=1 instead?

Gerd
________________________________________
Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag von lig fietser <ligfietser at hotmail.com>
Gesendet: Mittwoch, 8. Februar 2017 19:26:52
An: mkgmap-dev at lists.mkgmap.org.uk
Betreff: Re: [mkgmap-dev] [Patch] unpaved roads

I prefer v1, some remarks:

Please add paving_stones:30 (6012 cases)

I would suggest to set smoothness ~ '.*(very_bad|horrible|impassable)'  and give smoothness=bad a road_speed penalty. See https://forum.openstreetmap.org/viewtopic.php?id=57179

https://github.com/ligfietser/mkgmap-style-sheets/commit/1950f88900baaff405bab01887d7e7acbab799af

________________________________

Hi all,

I've created two different patches, both treat surface=cobblestone as paved.
The major difference between v1 and v2 is in the handling of possibly conflicting attributes.
For example, I found quite a lot of ways with
highway=track, surface=paved , tracktype=3
in my hometown area.
With v1 and also with unpatched default style this will be treated as unpaved, with v2 it is paved.

The logic in v2 is that we first find surface tags which say "road is paved" and for those roads
we will never set mkgmap:unpaved=1.

Which one would you prefer?

Gerd
_______________________________________________
mkgmap-dev mailing list
mkgmap-dev at lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: surface_v3.patch
Type: application/octet-stream
Size: 1608 bytes
Desc: surface_v3.patch
URL: <http://www.mkgmap.org.uk/pipermail/mkgmap-dev/attachments/20170209/daaffb50/attachment.obj>