[mkgmap-dev] crash in BinaryOp

Sat Oct 28 18:27:23 BST 2017

I included revision 3997 in my main build and am now getting a crash as
follows when I build my GB map (I don't get the crash on the small bit of
test data I previously used):

java.lang.NoSuchMethodError:
uk.me.parabola.mkgmap.osmstyle.eval.BinaryOp.setFirst(Luk/me/parabola/mkgmap
/osmstyle/eval/Op;)V
  at
uk.me.parabola.mkgmap.osmstyle.eval.ExpressionReader.runOp(ExpressionReader.
java:242)
  at
uk.me.parabola.mkgmap.osmstyle.eval.ExpressionReader.readConditions(Expressi
onReader.java:98)
  at
uk.me.parabola.mkgmap.osmstyle.RuleFileReader.loadFile(RuleFileReader.java:1
24)
  at
uk.me.parabola.mkgmap.osmstyle.RuleFileReader.load(RuleFileReader.java:95)
  at uk.me.parabola.mkgmap.osmstyle.StyleImpl.readRules(StyleImpl.java:285)
  at uk.me.parabola.mkgmap.osmstyle.StyleImpl.<init>(StyleImpl.java:155)
  at uk.me.parabola.mkgmap.osmstyle.StyleImpl.readStyle(StyleImpl.java:545)
  at
uk.me.parabola.mkgmap.reader.osm.OsmMapDataSource.createConverter(OsmMapData
Source.java:333)
  at
uk.me.parabola.mkgmap.reader.osm.OsmMapDataSource.setupHandler(OsmMapDataSou
rce.java:226)
  at
uk.me.parabola.mkgmap.reader.osm.OsmMapDataSource.parse(OsmMapDataSource.jav
a:168)
  at
uk.me.parabola.mkgmap.reader.osm.OsmMapDataSource.load(OsmMapDataSource.java
:150)
  at uk.me.parabola.mkgmap.main.MapMaker.loadFromFile(MapMaker.java:154)
  at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:52)
  at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:263)
  at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:259)

Looking at ExpressionReader.runOp, this calls

			BinaryOp binaryOp = (BinaryOp) op;
			binaryOp.setFirst(arg1);
			binaryOp.setSecond(arg2);

However, BinaryOp does not appear to have an implementation of setFirst or
getFirst.

Neither BinaryOp nor ExpressionReader were changed in this handover, so this
looks like a bug that was already there.

Regards,
Mike