[mkgmap-dev] patch for crash in MapSource

Thu Feb 8 19:05:54 GMT 2018

Hi Thomas,

the patch is based in r4107, this contains a change from Steve.

I am  not sure if your syntax is wrong or not. Please try this:
amenity=guidepost | amenity=signpost | (tourism=information & information=guidepost) {add name='$(name:de')|'$(name)'|'Wegweiser'} [0x4c01 resolution 24]

I've removed a pair of () .

Gerd

________________________________________
Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag von Thomas Morgenstern <webmaster at img2ms.de>
Gesendet: Donnerstag, 8. Februar 2018 19:49
An: Development list for mkgmap
Betreff: Re: [mkgmap-dev] patch for crash in MapSource

This version has a problem reading stylefile. It gives me the following error :Error in style:Error: (points:240): quoted word found where command expected. Could not open style.
Line 240 is :
amenity=guidepost | amenity=signpost | (tourism=information & information=guidepost) {add name=('$(name:de')|'$(name)'|'Wegweiser')} [0x4c01 resolution 24]

this error never occured with older versions. like  mkgmap- r3997.  what is wrong ?

thomas
--------------------------------------------------
Von: "Gerd Petermann" <gpetermann_muenchen at hotmail.com>
Datum: Donnerstag, 8. Februar 2018 17:40
An: "Development list for mkgmap" <mkgmap-dev at lists.mkgmap.org.uk>
Betreff: Re: [mkgmap-dev] patch for crash in MapSource

> Hi all,
>
> I've created patches for splitter and mkgmap.
> The binaries are here:
> http://files.mkgmap.org.uk/download/417/splitter.jar
> http://files.mkgmap.org.uk/detail/416
>
> Please try splitter with align-for-dem=360. I found no more crashes as long
> as used only one dem level, e.g. dem-dists=3312 or dem-dists=9936
>
> Maybe you find a combination of  align-for-dem and dem-dists with more than one value
> that still works, I'll try again tomorrow.
>
> Gerd
>
> ________________________________________
> Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag von Gerd Petermann <gpetermann_muenchen at hotmail.com>
> Gesendet: Donnerstag, 8. Februar 2018 13:16
> An: Development list for mkgmap
> Betreff: Re: [mkgmap-dev] patch for crash in MapSource
>
> Hi all,
>
> the patch contained a stupid bug, but there is more to this:
> 1) the effect of the patch depends on the dem-dists value (I assume only the one
> that gives the highest resolution). The higher the resolution the better it works.
> 2) it probably also depends on the boundaries (areas.list)
>
> I assume now that the tile boundary from areas.list should be a certain multiples of degrees,
> probably different multiples for lat and lon and that the overlap simply makes
> sure that this boundary is within the overlapped area.
> Maybe the preferred multiples also depend on the dem-dist.
>
> I'll try to find out more ...
>
> Gerd
>
> ________________________________________
> Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag von osm at pinns <osm at pinns.co.uk>
> Gesendet: Donnerstag, 8. Februar 2018 10:33
> An: mkgmap-dev at lists.mkgmap.org.uk
> Betreff: Re: [mkgmap-dev] patch for crash in MapSource
>
> Hi Gerd
>
> I think you are right ,ie
>
> start and finishing point  at same level seems OK eventhough the route
> turns south 20miles then up again
>
> r
>
> Nick
>
>
> On 08/02/2018 09:27, Gerd Petermann wrote:
>> Hi all,
>>
>> okay, thanks for testing. I'll try to find a better patch.
>> Please check: I think the patch works fine for routes which cross tile borders in horizontal direction
>> direction but I still see problems with vertical crossing. Can you confirm that?
>>
>> Gerd
>>
>> ________________________________________
>> Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag von Henning Scholland <osm at hscholland.de>
>> Gesendet: Donnerstag, 8. Februar 2018 09:59
>> An: Development list for mkgmap
>> Betreff: Re: [mkgmap-dev] patch for crash in MapSource
>>
>> Same for me, but just did quick test. Will try on the weekend more detailed
>> Henning
>> On 8 Feb 2018, at 16:57, lig fietser <ligfietser at hotmail.com<mailto:ligfietser at hotmail.com>> wrote:
>>
>> Hi Gerd,
>>
>> I tested your patch but I still see frequent crashes near tile borders.
>>
>>
>> ________________________________
>> Van: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> namens Gerd Petermann <GPetermann_muenchen at hotmail.com>
>> Verzonden: woensdag 7 februari 2018 02:45:27
>> Aan: mkgmap-dev at lists.mkgmap.org.uk
>> Onderwerp: [mkgmap-dev] patch for crash in MapSource
>>
>> Hi all,
>>
>> attached is a patch that seems to help in many cases where --dem-poly causes crashes in MapSource "Show Profile..."
>> A binary is here:
>> http://files.mkgmap.org.uk/download/414/mkgmap.jar
>>
>> It changes the TRE file and the *.tdb file.
>> I still see a few crashes but maybe those are caused by other problems.
>>
>> Please try and let me know your results. I found no bad impact so far,
>> long distance routing still seems to work, but I've not tested much.
>>
>> @Steve: Maybe we have to make sure that the areas in *.tdb do not overlap.
>> In this case this patch is not yet okay.
>>
>> Gerd
>>
>> ________________________________
>>
>> mkgmap-dev mailing list
>> mkgmap-dev at lists.mkgmap.org.uk
>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
>> _______________________________________________
>> mkgmap-dev mailing list
>> mkgmap-dev at lists.mkgmap.org.uk
>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
>
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-dev at lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-dev at lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
>

> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-dev at lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev