[mkgmap-dev] Bug in Road Merging - actually doubling roads.

Wed Mar 14 16:12:09 GMT 2018

Hi Gerd,

I get a huge huge list - and the ones I tried seemed to be quite alright -
but the couple that I checked where simply ways that my styles inserts at
least 3-4 times (usually ways with hiking/mtb route). Should I increase the
counter in the patch to 5 (I guess still alright) or to 6 (I'm pretty sure
I get routing errors then)?

Felix

On 13 March 2018 at 11:03, Gerd Petermann <gpetermann_muenchen at hotmail.com>
wrote:

> Hi Felix,
>
> attached is a patch that prints an error message when a route node has 4
> or more arcs with the same initial bearing.
> From your previous posts I understand that this might be the cause for
> crashes in the device. Please try the patch with
> r4135 from the angles branch. If it prints messages please try if you can
> reproduce crashes.
> The message might look like this:
> 4 or more arcs with the same initial bearing, expect routing problems at
> 41.833628,12.887826 when routing to 20° (http://www.openstreetmap.org/
> browse/way/198926993)
> The reported way id might not be correct when RoadMerger combined the
> reported way with others.
>
> Maybe we have to separate forward and backward arcs, in this case the code
> might produce too many warnings.
> Once we know what exactly is causing trouble we may be able to find code
> to avoid it.
>
> Gerd
>
> ________________________________________
> Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag von
> Gerd Petermann <gpetermann_muenchen at hotmail.com>
> Gesendet: Sonntag, 11. März 2018 16:39:47
> An: Development list for mkgmap
> Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
>
> Hi Felix,
>
> thanks for testing. Yes, roundabouts have to be split as well as all other
> closed or self intersecting ways.
> I guess the img format does not allow closed arcs.
>
> Gerd
>
> ________________________________________
> Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag von
> Felix Hartmann <extremecarver at gmail.com>
> Gesendet: Sonntag, 11. März 2018 15:13:06
> An: Development list for mkgmap
> Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
>
>
> Hi Gerd,
> oh - I had a different layout in gpsmapedit with 0x13 set to invisible and
> not used to opening gpsmapedit from my laptop. So the map was actually
> correct:
>
> https://www.openstreetmap.org/node/1263658804
> https://www.openstreetmap.org/node/1195812701
> is now fine - though of course the visible rendering is not really
> representing how it looks in reality - but broken routing is fixed.
>
>
> https://www.openstreetmap.org/node/1270407079
> as you said is still spiking - and actually with my style in that case
> also wrongly ending up in 6 routable lines. For me really a simple remove
> all semi connected ways at minimum length filter would be fine. I would
> just remove clutter of micromapping.
>
>
>
> As for the roundabouts.
> 1. https://www.openstreetmap.org/way/208976154
> looks fine - just strange that way https://www.openstreetmap.org/
> way/447282006 is not merged - all the others are merged.
>
> 2. https://www.openstreetmap.org/way/312642720
> a bit strange that it gets split into 2 ways. Routing seems fine. (the NNE
> section of the roundabout between the exit and entry is separated)
>
> 3. https://www.openstreetmap.org/way/148634420
> actually looks much better then with older versions of mkgmap. Looks
> pretty round - with a 3 month old mkgmap version (sorry don't have
> unpatched to compare) it was not very round. Routing is fine.
> Although here the north section is split off into a seperate way- it this
> a need for roundabouts?
>
>
>
> Felix
>
>
>
> On 10 March 2018 at 18:36, Gerd Petermann <gpetermann_muenchen at hotmail.com
> <mailto:gpetermann_muenchen at hotmail.com>> wrote:
> Hi Felix,
>
> please double check. The patch should not have such an effect, at least not
> in general.
> Maybe you changed the routing options?
>
> Gerd
>
>
>
> --
> Sent from: http://gis.19327.n8.nabble.com/Mkgmap-Development-f5324443.html
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-dev at lists.mkgmap.org.uk<mailto:mkgmap-dev at lists.mkgmap.org.uk>
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
>
>
>
> --
> Felix Hartman - Openmtbmap.org & VeloMap.org
> Schusterbergweg 32/8
> 6020 Innsbruck
> Austria - Österreich
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-dev at lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
>
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-dev at lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
>

-- 
Felix Hartman - Openmtbmap.org & VeloMap.org
Schusterbergweg 32/8
6020 Innsbruck
Austria - Österreich
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mkgmap.org.uk/pipermail/mkgmap-dev/attachments/20180314/ace0b83e/attachment.html>