[mkgmap-dev] Error in my style with Version mkgmap-r4136

Wed Mar 28 17:53:22 BST 2018

Hi Gerd

> looks good for me, although you may simplify the code in isIndexable():
> a) The expression ((ValueOp) op.getFirst()).isIndexable() appears three times
> b) the term (op.getSecond().isType(VALUE) || op.getSecond().isType(FUNCTION) appears two times and I wonder why it is needed.
> Do you have an example? The unit tests don't fail when I remove it.

OK a lot of that is not needed any more.

The attached patch returns isIndexable() to its simplest form and
all the other code is changed to fit.

Steve

-------------- next part --------------
A non-text attachment was scrubbed...
Name: expr-func2.patch
Type: text/x-patch
Size: 5017 bytes
Desc: not available
URL: <http://www.mkgmap.org.uk/pipermail/mkgmap-dev/attachments/20180328/25b663e9/attachment.bin>