[mkgmap-dev] Commit r4182: improve RuleIndex: Reduce number of evaluated rules
From Gerd Petermann gpetermann_muenchen at hotmail.com on Fri Apr 27 07:40:41 BST 2018
Hi all, attached are two log files created with the default style for a tile in Hamburg. If you compare them with a good file comparer you can see that the number of evaluated rules are smaller while the number of executed rules don't change (last value in the log) Typical effect of the change for rules that look for a specific value: INFO: uk.me.parabola.mkgmap.osmstyle.stats \hh\63240003.osm.pbf: points stats (rule/evals/true) $amenity=biergarten [0x2d02 level 0]/5596/4 INFO: uk.me.parabola.mkgmap.osmstyle.stats \hh\63240003.osm.pbf: points stats (rule/evals/true) $amenity=biergarten [0x2d02 level 0]/4/4 Sorry, the numbers are at the end of the lines, so comparison is a bit tricky. This shows: The old code evaluated all rules with amenity= when for node with the amenity tag. The effect on run time is not that big, maybe a few percent. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag von svn commit <svn at mkgmap.org.uk> Gesendet: Freitag, 27. April 2018 08:20:04 An: mkgmap-svn at lists.mkgmap.org.uk; mkgmap-dev at lists.mkgmap.org.uk Betreff: [mkgmap-dev] Commit r4182: improve RuleIndex: Reduce number of evaluated rules Version mkgmap-r4182 was committed by gerd on Fri, 27 Apr 2018 improve RuleIndex: Reduce number of evaluated rules The old index returned more rules than needed, thus the style evaluation was slowed down a bit. You can use logging to find the actual changes with this setting in logging.properties: uk.me.parabola.mkgmap.osmstyle.stats.level=INFO Slightly modified tags3.patch. http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4182 _______________________________________________ mkgmap-dev mailing list mkgmap-dev at lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -------------- next part -------------- A non-text attachment was scrubbed... Name: logs.zip Type: application/x-zip-compressed Size: 28872 bytes Desc: logs.zip URL: <http://www.mkgmap.org.uk/pipermail/mkgmap-dev/attachments/20180427/74ae2733/attachment-0001.bin>
- Previous message: [mkgmap-dev] Commit r4182: improve RuleIndex: Reduce number of evaluated rules
- Next message: [mkgmap-dev] Commit r4183: add unit test that failed with code in r3821
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
More information about the mkgmap-dev mailing list