[mkgmap-dev] methods to write signed / unsigned integers

Tue May 15 10:14:25 BST 2018

Hi Gerd

This case of composing 12bit lat and lon values into 3 bytes should use
put3s() with the way the code is at the moment; the first val (latOff)
is signed and shifting it preserves the sign so the whole thing is
allowed to be negative.

However:

1/ It would be clearer to mask both the lat and lon when composing the
value, then it should use put3u

2/ Examples like this might suffer the +-180 degree problem you've
noted in your other post. I think this one won't because they are
offsets from a center.

3/ My preference is for flags and butmasks to be handled as unsigned,
especially as a lot of them contain smaller unsigned values in the
bottom bits

Ticker

On Tue, 2018-05-15 at 05:27 +0000, Gerd Petermann wrote:
> Hi Ticker,
> 
> will check today. I've just noted that we use put3s to write a
> bitmask in RouteNode.java. It probably cannot cause problems but I
> think it should be put3u.
> See attached patch.
> 
> Gerd
> 
> ________________________________________
> Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag
> von Ticker Berkin <rwb-mkgmap at jagit.co.uk>
> Gesendet: Montag, 14. Mai 2018 14:48:01
> An: Development list for mkgmap
> Betreff: Re: [mkgmap-dev] methods to write signed / unsigned integers
> 
> Here is display patch based on r537
> 
> Ticker
> 
> On Mon, 2018-05-14 at 12:18 +0000, Gerd Petermann wrote:
> > Hi Steve, Hi Ticker,
> > 
> > okay, I've removed NodConvert.
> > 
> > @Ticker: If you have a working patch based on r537, please post it.
> > 
> > Gerd
> > 
> > ________________________________________
> > Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag
> > von Steve Ratcliffe <steve at parabola.me.uk>
> > Gesendet: Montag, 14. Mai 2018 14:07:20
> > An: mkgmap-dev at lists.mkgmap.org.uk
> > Betreff: Re: [mkgmap-dev] methods to write signed / unsigned
> > integers
> > 
> > On 14/05/18 12:42, Gerd Petermann wrote:
> > > I am not sure what to do with NodConvert. I think the code is
> > > wrong, it fails on NOD with restrictions, but I never use the
> > > program
> > > so I don't want to invest the time to fix it.
> > > @Steve: What do you think?
> > 
> > I have no interest in NodConvert, if it not useful just delete
> > it.use.
> > 
> > NodConvert is from 2008/9. When we improved routing in 2014 I used
> > the test.svg.nod program to visualise the routing network.  That is
> > far
> > more complete and useful.
> > 
> > Steve
> > _______________________________________________
> > mkgmap-dev mailing list
> > mkgmap-dev at lists.mkgmap.org.uk
> > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> > _______________________________________________
> > mkgmap-dev mailing list
> > mkgmap-dev at lists.mkgmap.org.uk
> > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-dev at lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev