[mkgmap-dev] Lake Garda... is empty

Fri Sep 21 08:59:07 BST 2018

Hi all,

sorry for the late response, I was cycling for a few weeks ;-)
I've now moved the two includes as I suggested in the post cited by Ticker.

@Steve: I don't know why you created these includes. I also think it would be easier to have the rules within the polygons file.

Gerd

________________________________________
Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag von Ticker Berkin <rwb-mkgmap at jagit.co.uk>
Gesendet: Mittwoch, 12. September 2018 11:06
An: Development list for mkgmap
Betreff: Re: [mkgmap-dev] Lake Garda... is empty

Maybe this should become a new thread on style/default:

I find the includes of inc/{landuse,water}_{points,lines,polygons}
pointless and unhelpful for various reasons:

1/ Each file is only included once so there is no advantage in avoiding
repetition.

2/ Checking the files to determine the behaviour for a tag is more
difficult - you can't just to a search from the top of 1 file.

3/ The contents of some of the files is not quite as the name suggests,
eg landuse_polygons tests for other tags.

4/ Some of the cases that you'd expect to be in the include file based
on its name have been moved out or duplicated into the parent file,
with intervening logic before the include, eg points and
landuse=military/village_green

5/ I suspect there are other cases where the contents of an include
file need to be scattered more intelligently into the parent file

Ticker

On Tue, 2018-09-11 at 21:42 +0200, Enrico Liboni wrote:
> Ticker, Lig - many thanks the lake is back now!  I moved
> 'inc/*_polygons' as suggested.
>
> I'll test further to see if any adverse impact, but it does not seems
> the case so far. Guess this change should be made in the default
> style in next release, since we may have other lakes or bays that are
> labelled as tourist=yes - which may not be wrong for scenic touristic
> areas.
>
> Thanks!
> Enrico
>
> On Tue, Sep 11, 2018 at 7:20 PM Ticker Berkin <rwb-mkgmap at jagit.co.uk
> > wrote:
> > Hi
> >
> > I seem to remember there was a suggestion a while ago (before may
> > 2017)
> > to reorder the styles/default/polygons to move the include
> > 'inc/*_polygons' up in the file to before "# building tag should be
> > last". I did this and had no problem with Lake Garda when I
> > generated
> > italy-latest in July this year.
> >
> > Ticker
> >
> > Just found the thread:
> > http://www.mkgmap.org.uk/pipermail/mkgmap-dev/2017q2/026788.html
> >
> > On Tue, 2018-09-11 at 12:30 +0000, lig fietser wrote:
> > > Hi,
> > > I can reproduce your findings with the default style. With the
> > > generic new or my Openfietsmap style it renders fine so it seems
> > > style dependend.
> > > I found out the tourism=yes tag from the multipoly relation is
> > the
> > > cause. Once removed, it renders. Can this be fixed in mkgmap
> > (natural
> > > before tourism?) or should this tag be removed from osm?
> > > _______________________________________________
> > > mkgmap-dev mailing list
> > > mkgmap-dev at lists.mkgmap.org.uk
> > > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> > _______________________________________________
> > mkgmap-dev mailing list
> > mkgmap-dev at lists.mkgmap.org.uk
> > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> >
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-dev at lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
_______________________________________________
mkgmap-dev mailing list
mkgmap-dev at lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev