[mkgmap-dev] default style improvements

Sat Jan 5 08:43:09 GMT 2019

Hi Ticker,

it would be easier to check if you would not mix simple optical changes (additional/removed blanks) with functional changes ;)
I'd also prefer smaller patches, each one adressing only one problem. This makes it easier to discuss the patch.

1) I do not yet understand the changes regarding area=yes and multipolygons. Can you explain that, please?
2) Why are the rules for food POI moved behind e.g.  tourism=hotel?  I think you often find OSM objects tagged with both amenity=restaurant and tourism=hotel,
and I'd prefer to find both. Probably a case for continue ?

Gerd

________________________________________
Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag von Ticker Berkin <rwb-mkgmap at jagit.co.uk>
Gesendet: Donnerstag, 3. Januar 2019 17:52
An: Development list for mkgmap
Betreff: Re: [mkgmap-dev] default style improvements

Hi Gerd

Here is another patch. I've made the changes as you suggested and the
following changes:

When highway=path is converted into a cycleway or bridleway, add
foot=yes in case the inc/access[_country] rules don't allow foot on the
resultant highway type

Restrict which historic= are shown as polygons. The original patch
widened this too much.

Regards
Ticker

On Thu, 2019-01-03 at 14:56 +0000, Gerd Petermann wrote:
> Hi Ticker,
>
> yes please, my understanding was that the patch was not accepted.
>
> Gerd
>
> ________________________________________
> Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag
> von Ticker Berkin <rwb-mkgmap at jagit.co.uk>
> Gesendet: Donnerstag, 3. Januar 2019 11:59
> An: Development list for mkgmap
> Betreff: Re: [mkgmap-dev] default style improvements
>
> Hi Gerd
>
> Do you want me to do another version of this patch before you commit
> it?
>
> I'd like to get on with the next set of changes; minor things like
> removing horse= can be done with these.
>
> Regards
> Ticker
>
> On Thu, 2018-12-13 at 10:54 +0000, Ticker Berkin wrote:
> > Hi Gerd
> >
> > My rationale was to see what highway= tags from various european
> > countries the default style didn't handle and hence generated:
> >
> > [0x07 road_class=0 road_speed=0 resolution 23]
> >
> > and then decide to:
> >
> > a) explicitly ignore.
> > b) handle as if they were a well defined highway type,
> >    with appropriate access control.
> > c) generate a new line type, with routing as appropriate.
> > d) allow mop-up as above.
> >
> > I removed escape/emergency_bay because I didn't think they added
> > anything useful to routing or the resultant map.
> >
> > footpath/foot looked like they should be footway or path, but if
> > you
> > think they should be ignored, I have no problem with that.
> >
> > What remained after this exercise was a few rubbish tags and lots
> > of
> > highway={real name of street} and I'd rather have these on my map
> >
> > The {add horse=xxx} I just changed a bit to be in keeping with what
> > was
> > there already but happy to delete it.
> >
> > Ticker
> >
> > On Thu, 2018-12-13 at 09:18 +0000, Gerd Petermann wrote:
> > > Hi Ticker,
> > >
> > > I think it is not a good idea to remove  highway=escape or
> > > highway=emergency_bay. The last time I looked at them most where
> > > correctly mapped.
> > > I'd also remove horse=yes or horse=no unless you want evaluate
> > > that
> > > somewhere in the style. Don't know why it is in the current
> > > default
> > > style.
> > > There is no code in mkgmap to evaluate it.
> > >
> > > Reg. rules like
> > > highway=footpath | highway=foot {set highway=footway}  # fix
> > > common
> > > bad tagging
> > > I think we don't need them. Most of those ways are mapped by HOT
> > > projects, it is very likely that they are not connected or self
> > > intersecting etc.
> > > I'd rather remove the mop up rule instead of adding a lot of "try
> > > to
> > > guess better" rules.
> > >
> > > Gerd
>
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-dev at lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-dev at lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev