[mkgmap-dev] Commit r4270: improve reader for polish (*.mp) format

Sun Feb 10 08:26:29 GMT 2019

Hi Andrzej,

I found an older example with restrictions and I can reproduce the problem. It seems that our reader is too restrictive regarding the spelling of key words.
For example, the parser understands "TraffPoints" but not "TRAFFPOINTS"

I can try to change the parser so that it always uses method String.equalsIgnoreCase() instead of String.equals().

Gerd

________________________________________
Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag von Gerd Petermann <gpetermann_muenchen at hotmail.com>
Gesendet: Sonntag, 10. Februar 2019 06:42
An: Development list for mkgmap
Betreff: Re: [mkgmap-dev] Commit r4270: improve reader for polish (*.mp) format

Hi Andrzej,

please can you share your input file 00008001.mp?

Gerd

________________________________________
Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag von Andrzej Popowski <popej at poczta.onet.pl>
Gesendet: Sonntag, 10. Februar 2019 00:41
An: mkgmap-dev at lists.mkgmap.org.uk
Betreff: Re: [mkgmap-dev] Commit r4270: improve reader for polish (*.mp) format

Hi Gerd,

I have tried to compile some more complicated mp. First problem is, that
restriction placed on the beginning of the file give multiple warnings,
like:

SEVERE (RoadNetwork): 00008001.mp: 1 can't locate arc from 'via' node  1
to 'to' node 171 on way 431744
SEVERE (RoadNetwork): 00008001.mp: 4 can't locate arc from 'via' node  4
to 'to' node 59519 on way 1020461
SEVERE (RoadNetwork): 00008001.mp: 8 can't locate arc from 'via' node  8
to 'to' node 80234 on way 812265

Then mkgmap crashes:

java.lang.NullPointerException
         at
uk.me.parabola.imgfmt.app.net.RoadNetwork.addRestriction(RoadNetwork.java:320)
         at
uk.me.parabola.mkgmap.general.MapDetails.addRestriction(MapDetails.java:130)
         at
uk.me.parabola.mkgmap.reader.polish.RestrictionHelper.processAndAddRestrictions(RestrictionHelper.java:54)
         at
uk.me.parabola.mkgmap.reader.polish.PolishMapDataSource.load(PolishMapDataSource.java:151)
         at
uk.me.parabola.mkgmap.main.MapMaker.loadFromFile(MapMaker.java:154)
         at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:52)
         at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:289)
         at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:285)
         at java.util.concurrent.FutureTask.run(Unknown Source)
         at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown
Source)
         at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown
Source)
         at java.lang.Thread.run(Unknown Source)
Exiting - if you want to carry on regardless, use the --keep-going option

If I move restriction to the end of file, then there is no warning, but
crash is the same:

java.lang.NullPointerException
         at
uk.me.parabola.imgfmt.app.net.RoadNetwork.addRestriction(RoadNetwork.java:320)
         at
uk.me.parabola.mkgmap.general.MapDetails.addRestriction(MapDetails.java:130)
         at
uk.me.parabola.mkgmap.reader.polish.RestrictionHelper.processAndAddRestrictions(RestrictionHelper.java:54)
         at
uk.me.parabola.mkgmap.reader.polish.PolishMapDataSource.load(PolishMapDataSource.java:151)
         at
uk.me.parabola.mkgmap.main.MapMaker.loadFromFile(MapMaker.java:154)
         at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:52)
         at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:289)
         at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:285)
         at java.util.concurrent.FutureTask.run(Unknown Source)
         at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown
Source)
         at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown
Source)
         at java.lang.Thread.run(Unknown Source)
Exiting - if you want to carry on regardless, use the --keep-going option

--
Best regards,
Andrzej
_______________________________________________
mkgmap-dev mailing list
mkgmap-dev at lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
_______________________________________________
mkgmap-dev mailing list
mkgmap-dev at lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev