[mkgmap-dev] TREHeader.POI_FLAG_DETAIL, transparent and map background

Tue Mar 26 10:25:21 GMT 2019

Hi Ticker,

thanks for the information. When I added the code in MapBuilder to set TREHeader.POI_FLAG_DETAIL I did not even think about
all-elements.
I also never noticed that the map has no background polygon 0x4b. I think the proper way to handle this is to set
the transparent flag in ElementTestDataSource.getPoiDispFlag().
Do you agree?

Gerd

________________________________________
Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag von Ticker Berkin <rwb-mkgmap at jagit.co.uk>
Gesendet: Montag, 25. März 2019 17:56
An: mkgmap development
Betreff: [mkgmap-dev] TREHeader.POI_FLAG_DETAIL,        transparent and map background

Hi

I noticed a while ago that "test-map:all-elements" stopped working
correctly. The map it generated showed a box around the map area, but
within the map area, the device said 'no-map' and didn't show anything,
however POI searches did work.

I tracked it down to a couple of lines added to
mkgmap/build/MapBuilder.java : processInfo()

                if (!(src instanceof OverviewMapDataSource))
                        poiDisplayFlags |= TREHeader.POI_FLAG_DETAIL;

poiDisplayFlags is byte 0x3f in TRE

So:

Old maps and old all-elements, with poiDisplayFlags = 0 worked.

New maps, with poiDisplayFlags = POI_FLAG_DETAIL, work, but all
-elements doesn't.

One of differences between a typical map and all-elements is that all
-elements doesn't output a standard background (polygon 0x4b covering
the complete map area); changing it to do so, then all features get
displayed.

However, transparent maps don't have a standard background and they
work. Trying option --transparent with the original version of all
-elements makes it work.

I don't know if this behaviour was known or expected, but I thought it
worth-while to note it down in this post.

I didn't want all-elements to have a standard background so I've added
--transparent to the comment about how to invoke it, also a few other
option suggestions.

The other change I made was to show elements against a green background
as well as no background, as I was having trouble spotting many line
-types that my new device shows as white.

I've attached a patch for this.

Regards
Ticker

-------------- next part --------------
A non-text attachment was scrubbed...
Name: allElem-v2.patch
Type: application/octet-stream
Size: 1776 bytes
Desc: allElem-v2.patch
URL: <http://www.mkgmap.org.uk/pipermail/mkgmap-dev/attachments/20190326/ed5bbde7/attachment.obj>