[mkgmap-dev] missing check for option --family-id

Tue Apr 7 14:07:50 BST 2020

Hi,

I am not sure about the lower limit of 1. Zero may be acceptable. The 
upper limit should be checked for as some Garmin receivers have problems 
with file names\ prefixes longer than eight characters, which comes from 
the old MSDOS FAT limit of 8 character prefix and 3 character suffix 
file name format.

Randolph J. Herber

On 4/7/2020 5:08 AM, Gerd Petermann wrote:
> Hi all,
> in the garmin forum there is a discussion about the range :
> https://forum.openstreetmap.org/viewtopic.php?pid=782395#p782395
>
> The current options.txt says
> --family-id=integer
>      This is an integer that identifies a family of products. Range: [1..9999]
>      Default: 6324
>
> This limit is neither checked nor is it correct. The corresponding value is stored in a two byte field and most mkgmap sources interpret it as a 16-bit-unsigned integer.
> However, in class uk.me.parabola.tdbfmt.HeaderBlock the field is stored in a short (signed 16-bit-int).
>
> My conclusion: We should print a warning when the value given in --family-id is < 0 or > 32767.
>
> Gerd
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-dev at lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev