[mkgmap-dev] Crash in NodCheck

Thu Jul 9 07:31:26 BST 2020

Hi Steve,

reg. flags==0:
yes, the Hungary demo map contains nodes with flags==0 but it might not be a good example map. Routing in this map typically gives weird results in Basecamp.
I also see such a node in the transalpin demo map (display tool r552)
         |        |                         |
         |        |                         | New node
000000b7 | 00002a | 02                      | low 2
000000b8 | 00002b | 00                      | Flags 0
         |        |                         | : no-arcs destclass=0
000000b9 | 00002c | 26 8f 15                | longitude 11.09533 -218
         |        |                         | latitude 46.90902 +344

Routing results look OK in this map but it is probably too small for a test case.

Anyway, I think I'll commit your patch for now and try to find out more about special cases with end nodes.

Gerd

________________________________________
Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag von Gerd Petermann <gpetermann_muenchen at hotmail.com>
Gesendet: Mittwoch, 8. Juli 2020 22:35
An: Development list for mkgmap
Betreff: Re: [mkgmap-dev] Crash in NodCheck

Hi Steve,

I found no node with low==0 and flag==0 in Garmin maps, but I think there are ones with flags==0.
I have to double check but I think there are tiles in a demo map for Hungaria.

Gerd

________________________________________
Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag von Steve Ratcliffe <steve at parabola.me.uk>
Gesendet: Mittwoch, 8. Juli 2020 21:57
An: mkgmap-dev at lists.mkgmap.org.uk
Betreff: Re: [mkgmap-dev] Crash in NodCheck

Hi

>  > the current code in NodCheck (NodFile.java) stops reading route nodes
> when
>  >         if (low == 0 && flags == 0)
>  >             return null;
>
> Yes your right that check is not needed, because we know the correct
> size of the section.

Sorry this is wrong; we know the size of the section but the entries are
variable size and there has to be a way to know when we have found the
last one.

I think that flags==0 is the marker.  Have you seen any Garmin map with
flags==0?

It seems to me that a node is either on the boundary or has arcs, or
else it is not a routing node.

Steve
_______________________________________________
mkgmap-dev mailing list
mkgmap-dev at lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
_______________________________________________
mkgmap-dev mailing list
mkgmap-dev at lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev