[mkgmap-dev] Tiles pruned in DEM map

Sat Jan 23 11:29:26 GMT 2021

Hi Ticker,

outch, sorry! It seems I created my patch without any testing :(
I'm still not happy with the handling of the --order-by-decreasing-area option. I wonder why nobody else comments on this. Either nobody cares about the size of the overview map or nobody else tried any of the patches. Since this is a major change I hoped for more feedback.

Gerd

________________________________________
Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag von Ticker Berkin <rwb-mkgmap at jagit.co.uk>
Gesendet: Samstag, 23. Januar 2021 12:04
An: Development list for mkgmap
Betreff: Re: [mkgmap-dev] Tiles pruned in DEM map

Hi Gerd

I hadn't rebuilt after taking your patch. You had removed a declaration
of bounds, exposing a different one.

Patch attached.

Ticker

On Sat, 2021-01-23 at 10:27 +0000, Gerd Petermann wrote:
> Hi Ticker,
>
> I used mkgmap r4597  patched with overview-v5.patch on the output of
> splitter with Rankos split command:
> E:\rj-mp-split>java -jar d:\mkgmap\dist\mkgmap.jar 80100004.osm.pbf
> Time started: Sat Jan 23 11:23:51 CET 2021
> Number of MapFailedExceptions: 0
> Exception in thread "main" java.lang.NullPointerException: Cannot
> invoke "uk.me.parabola.imgfmt.app.Area.getMaxDimension()" because
> "detailTileBounds" is null
>         at
> uk.me.parabola.mkgmap.combiners.OverviewBuilder.checkFixRes(OverviewB
> uilder.java:146)
>         at
> uk.me.parabola.mkgmap.combiners.OverviewBuilder.addMapCoverageArea(Ov
> erviewBuilder.java:397)
>         at
> uk.me.parabola.mkgmap.combiners.OverviewBuilder.readFileIntoOverview(
> OverviewBuilder.java:264)
>         at
> uk.me.parabola.mkgmap.combiners.OverviewBuilder.onMapEnd(OverviewBuil
> der.java:89)
>         at uk.me.parabola.mkgmap.main.Main.endOptions(Main.java:649)
>         at
> uk.me.parabola.mkgmap.CommandArgsReader.readArgs(CommandArgsReader.ja
> va:125)
>         at uk.me.parabola.mkgmap.main.Main.mainStart(Main.java:144)
>         at uk.me.parabola.mkgmap.main.Main.main(Main.java:115)
>
>
> No such exception with unpatched mkgmap.
>
> Gerd
>
> ________________________________________
> Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag
> von Ticker Berkin <rwb-mkgmap at jagit.co.uk>
> Gesendet: Samstag, 23. Januar 2021 11:20
> An: Development list for mkgmap
> Betreff: Re: [mkgmap-dev] Tiles pruned in DEM map
>
> Hi Gerd
>
> I've just tried this and don't get a problem (with or without -ea)
>
> I used Ranko's osm.pbf, splitter-r595 and my development mkgmap which
> is trunk + overview patch + couple of trivial changes.
>
> Where were you getting the exception?
>
> Ticker
>
>
> On Sat, 2021-01-23 at 07:18 +0000, Gerd Petermann wrote:
> > Hi Ticker,
> >
> > I just got a NullPointerException looking at the example from
> > Ranko.
> > Happens when I create a map without any option, just
> > java -jar mkgmap.jar 80100004.osm.pbf
> >
> > Gerd
>
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-dev at lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-dev at lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev