[mkgmap-dev] Re logging improvements

Sun Apr 11 12:14:37 BST 2021

Hi Gerd, 

Attached is the next small patch. This brings echo and echotags under
logging control.

Cheers,
Mike

-----Original Message-----
From: Mike Baggaley [mailto:mike at tvage.co.uk] 
Sent: 11 April 2021 09:59
To: 'Development list for mkgmap' <mkgmap-dev at lists.mkgmap.org.uk>
Subject: RE: [mkgmap-dev] Re logging improvements

Hi Gerd, 

The text of diagnostic.messages patch seems to me to accurately reflect what
happens now. If someone is using a logging config file, they should
hopefully know where they are asking the output to go and I don't think the
help should mention changes.

I suggest you ignore the other uncommitted patches I've passed to you and
I'll send some new ones to clarify where we are up to.

I mentioned in the text that the Tests.patch wouldn't work with the existing
code, because of some text that was previously going to stdout going to
stderr under the completed set of patches, so I don't expect that to be
committed yet.

Cheers,
Mike

-----Original Message-----
From: Gerd Petermann [mailto:gpetermann_muenchen at hotmail.com] 
Sent: 11 April 2021 08:46
To: Development list for mkgmap <mkgmap-dev at lists.mkgmap.org.uk>
Subject: Re: [mkgmap-dev] Re logging improvements

Hi Mike,

I fear I'm lost in patches ;)

Maybe you didn't want me to commit diagnostics.patch?
I've tried Tests.patch with r4649 and 3 unit tests fail.
The text in diagnosticmessages.patch should be adapted to our latest
findings reg. the commit message ("diagnostic messages are now written to
stderr unless using a logging configuration without a ConsoleHandler")

Gerd

________________________________________
Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag von Mike
Baggaley <mike at tvage.co.uk>
Gesendet: Freitag, 9. April 2021 09:30
An: 'Development list for mkgmap'
Betreff: [mkgmap-dev] Re logging improvements

Hi Gerd,

Please find attached the updated version of the patch. It adds
synchronisation of the static variables in StyledConverter and fixes the
unit test.

It includes the not yet committed changes in codepage.patch,
diagnostics.patch and Tests.patch.

Cheers,
Mike

-------------- next part --------------
A non-text attachment was scrubbed...
Name: echo.patch
Type: application/octet-stream
Size: 3058 bytes
Desc: not available
URL: <http://www.mkgmap.org.uk/pipermail/mkgmap-dev/attachments/20210411/c27b286d/attachment.obj>