[mkgmap-dev] remainder of logging changes

Tue Apr 13 09:20:25 BST 2021

Hi Steve,

please comment what you think about the trick with TestUtils.runAsProcess(). I think it might not work on the build server since
ant clean test
doesn't build \dist\mkgmap.jar.

Of course we can add target dist as a depency in build.xml to fix that, but I think you had reasons to avoid that?
Do you think this is the right way to go? Doesn't it somehow bypass the junit stuff?
Would it help to move to JUnit 5?

Gerd

________________________________________
Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag von Gerd Petermann <gpetermann_muenchen at hotmail.com>
Gesendet: Dienstag, 13. April 2021 08:52
An: Development list for mkgmap
Betreff: Re: [mkgmap-dev] remainder of logging changes

Hi Mike,

reg. diagnosticmessages.patch:
My understanding of the text is that you get rid of the console messages if you use a logging configuration file. When I try this with my existing config file I don't see this effect because the configuration tells the logger to also write those messages to the console.
A similar config can be found in the wiki
https://wiki.openstreetmap.org/wiki/Mkgmap/dev#Enabling_Debugging

So, what I am missing is the hint that the config file should NOT contain a console handler.

Writing this I wonder if it is now impossible to see only error messages on stderr when the reporting options are enabled?

Gerd

________________________________________
Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag von Mike Baggaley <mike at tvage.co.uk>
Gesendet: Montag, 12. April 2021 17:56
An: 'Development list for mkgmap'
Betreff: [mkgmap-dev] remainder of logging changes

Hi Gerd,

Please find attached a patch with the remainder of the logging changes
(apart from CommandArgs).

There are changes to the main program so that the dates and times are only
output if mkgmap is processing one or more files.

The patch includes an update to the unit test. Note that this now takes a
little longer to run, because of having to create new processes to run some
of the tests.

BTW, were you expecting a change to diagnosticmessages.patch, or is it OK as
it stands? (I've attached a copy in case it got lost amongst all the
others.)

Cheers,
Mike
_______________________________________________
mkgmap-dev mailing list
mkgmap-dev at lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev