[mkgmap-dev] Duplicate roads added by default style

Mon May 10 11:37:10 BST 2021

Hi Gerd

This is incorrect tagging. highway=platform should be used just for bus
or tram, not for railway.

However, no problem with your change to the default style.

I don't think it is worthwhile extending de-duplication to other
elements; just the strange cases that road-merger throws up.

Ticker

On Mon, 2021-05-10 at 10:04 +0000, Gerd Petermann wrote:
> Hi all,
> 
> in my area a lot platforms have highway=platform and
> railway=platform, and the default  style adds a routable way for
> both.
> 
> The default style could be fixed with
> railway=platform & tmp:stopMopUp!=yes [0x16 road_class=0 road_speed=0
> resolution 23]
> instead of
> railway=platform [0x16 road_class=0 road_speed=0 resolution 23]
> 
> The code to find duplicate roads for the same OSM way is rather
> simple. I could add more code to find this issue for other objects
> (points, shapes, other lines) as well but I guess roads are the most
> important?
> 
> Gerd
> 
> ________________________________________
> Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag
> von Ticker Berkin <rwb-mkgmap at jagit.co.uk>
> Gesendet: Montag, 10. Mai 2021 11:51
> An: Development list for mkgmap
> Betreff: Re: [mkgmap-dev] Duplicate roads added by default style
> 
> Hi all
> 
> Maybe railway=platform shouldn't generate a routable line.
> 
> Pure duplication of (parts of) roads with identical Garmin img
> attributes could be suppressed. These could come from duplication by
> the style or distinct OSM ways. In the case of platform=railway, I'd
> have thought it to be better mapping to have a distinct OSM way when
> a
> navigable route uses a platform.
> 
> I don't have strong feelings about warnings or not for this case.
> 
> Ticker
> 
> On Mon, 2021-05-10 at 09:21 +0000, Gerd Petermann wrote:
> > Hi Felix,
> > 
> > sure, I meant roads which RoadMerger would combine. Roadmerger
> > checks
> > a lot more attributes.
> > Multiple (different) routable ways for one OSM way are quite
> > normal,
> > esp. with the --make-opposite-cycleways option.
> > 
> > I think it's worth to log a warning for each.
> > 
> > Gerd
> > 
> > ________________________________________
> > Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag
> > von Felix Hartmann <extremecarver at gmail.com>
> > Gesendet: Montag, 10. Mai 2021 11:16
> > An: Development list for mkgmap
> > Betreff: Re: [mkgmap-dev] Duplicate roads added by default style
> > 
> > It makes the style very complicated to try to remove any identical
> > copies - I do this by setting loads of temporary keys, that are
> > checked later for existing or not existing and based on that add or
> > not add other lines.  I guess some actual duplicates will still
> > happen.
> > 
> > On Mon, 10 May 2021 at 17:14, Felix Hartmann <
> > extremecarver at gmail.com
> > <mailto:extremecarver at gmail.com>> wrote:
> > hmm no, please no warning. This can be very beneficial. As long as
> > the type OR road_speed OR road_class OR oneway plus direction is
> > different. The above of course makes no sense, as it will set
> > exactly
> > the same road twice.
> > 
> > On Mon, 10 May 2021 at 16:49, Gerd Petermann <
> > GPetermann_muenchen at hotmail.com<mailto:
> > GPetermann_muenchen at hotmail.com>> wrote:
> > Hi all,
> > 
> > while double checking patch for the RoadMerger I wondered what
> > might
> > happen if the style adds two or more identical roads for the same
> > OSM
> > way.
> > Of course this makes no sense but to my surprise I found out that
> > this really happens with the default style.
> > A way with e.g. highway=footway and railway=platform is added twice
> > ...
> > highway=footway {set tmp:stopMopUp=yes} [0x16 road_class=0
> > road_speed=0 resolution 23 continue with_actions]
> > ...
> > railway=platform [0x16 road_class=0 road_speed=0 resolution 23]
> > 
> > Of course the default style should be fixed to avoid that but I
> > think
> > mkgmap can detect this easily and should print a warning when the
> > style does that?
> > 
> > Gerd
> > _______________________________________________
> > mkgmap-dev mailing list
> > mkgmap-dev at lists.mkgmap.org.uk<mailto:
> > mkgmap-dev at lists.mkgmap.org.uk>
> > https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> > 
> > 
> > --
> > Felix Hartman - Openmtbmap.org & VeloMap.org
> > 
> > 
> > 
> > --
> > Felix Hartman - Openmtbmap.org & VeloMap.org
> > 
> > _______________________________________________
> > mkgmap-dev mailing list
> > mkgmap-dev at lists.mkgmap.org.uk
> > https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-dev at lists.mkgmap.org.uk
> https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-dev at lists.mkgmap.org.uk
> https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev