[mkgmap-dev] [mkgmap-svn] Commit r4810: revert changes from r4809 for now, they caused more trouble

Fri Oct 29 08:13:29 BST 2021

Hi Ticker,

OK, patch looks more consistent then v2 where I wondered about the mix of String.equals() and collator.compare().
I have to run a few tests to understand the meaning of the change.

Any chance to create unit tests for this? I got the impression that the indexes work quite well in the past, at least for latin1.

Gerd

________________________________________
Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag von Ticker Berkin <rwb-mkgmap at jagit.co.uk>
Gesendet: Donnerstag, 28. Oktober 2021 13:20
An: Development list for mkgmap
Betreff: Re: [mkgmap-dev] [mkgmap-svn] Commit r4810: revert changes from r4809 for now, they caused more trouble

Hi Gerd

After considering all places where the createSortKey strength must be
set I've decided it isn't a good approach:

1/ It needs changes in NET and LBL as well as MDR.
2/ Because case-differences are not sorted, an apparently sorted and
unique list of city/region/country could be out of order if there are
case differences in the initial letters of duplicates.
This also makes mdrCheck comparisons difficult

This would have been mdrUnicode_v4.patch

Attached patch doesn't change the Key/Sort behaviour but follows the
sort with collator.compare where necessary instead of key.compareTo()
or .equals()

Ticker