[mkgmap-dev] [mkgmap-svn] Commit r4810: revert changes from r4809 for now, they caused more trouble

Mon Nov 1 12:31:23 GMT 2021

Hi Gerd

I realise now why I couldn't reproduce this behaviour with the case
distinction - I haven't been using --lower-case. My device shows
everything neatly in mixed case, even though all the data in .img is
upper. This also affects the how mdr builds the indexes - all case
variants look the same and are combined.

Ticker

On Fri, 2021-10-29 at 08:35 +0000, Gerd Petermann wrote:
> Hi Ticker,
> 
> patch v5 corrupts address search :(
> I tried the following command with the data from Arndt:
> (Arndt_NRWplus_mkgmapstyle.zip)
> java -Xmx5G -jar dist\mkgmap.jar --output-dir=e:/ld  --max-jobs --
> latin1 --gmapi --index 60050169.img 60050170.img 60050188.img
> 
> The three tiles contain data for cities "de Wijk" or "De Wijk" (two
> different cities and different spelling of the same city)
> 
> I test with Basecamp address search.
> 
> With the unpatched version I can find the street Cockserve in city De
> Wijk (OK), but not with the patched version. Basecamp shows the city
> name "De Wijk" when I seach for the road only, but obviously the
> index doesn't work. Same when I search for street Cockserve in city
> de Wijk
> 
> In MapSource the results are similar, but it doesn't suggest "De
> Wijk" as city name, only "de Wijk".
> 
> Gerd
> 
> ________________________________________
> Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag
> von Gerd Petermann <gpetermann_muenchen at hotmail.com>
> Gesendet: Freitag, 29. Oktober 2021 09:13
> An: Development list for mkgmap
> Betreff: Re: [mkgmap-dev] [mkgmap-svn] Commit r4810: revert changes
> from r4809 for now, they caused more trouble
> 
> Hi Ticker,
> 
> OK, patch looks more consistent then v2 where I wondered about the
> mix of String.equals() and collator.compare().
> I have to run a few tests to understand the meaning of the change.
> 
> Any chance to create unit tests for this? I got the impression that
> the indexes work quite well in the past, at least for latin1.
> 
> Gerd
> 
> ________________________________________
> Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag
> von Ticker Berkin <rwb-mkgmap at jagit.co.uk>
> Gesendet: Donnerstag, 28. Oktober 2021 13:20
> An: Development list for mkgmap
> Betreff: Re: [mkgmap-dev] [mkgmap-svn] Commit r4810: revert changes
> from r4809 for now, they caused more trouble
> 
> Hi Gerd
> 
> After considering all places where the createSortKey strength must be
> set I've decided it isn't a good approach:
> 
> 1/ It needs changes in NET and LBL as well as MDR.
> 2/ Because case-differences are not sorted, an apparently sorted and
> unique list of city/region/country could be out of order if there are
> case differences in the initial letters of duplicates.
> This also makes mdrCheck comparisons difficult
> 
> This would have been mdrUnicode_v4.patch
> 
> Attached patch doesn't change the Key/Sort behaviour but follows the
> sort with collator.compare where necessary instead of key.compareTo()
> or .equals()
> 
> Ticker
> 
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-dev at lists.mkgmap.org.uk
> https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-dev at lists.mkgmap.org.uk
> https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev