[mkgmap-dev] Small problem with global index

Fri Nov 26 17:06:08 GMT 2021

Hi Ticker,

I tried this: use your command to build a gmapi and gmapsupp, but replace r4810 by a binary compiled from mkgmap r4717 + mdrUnicode_v9b.patch
(I still see no difference in the output compared to unpatched r4717)

I then use MapSource to create another gmapsupp.
I run MdrDisplay and MdrCheck on both gmapsupp.img and see different repeat flags.
MdrCheck + my patch display-no-secondary.patch complains a lot about the gmapsupp with your patch but reports only 1 problem about a city without name.
When I try this with the unpatched display tool it complains a lot about the gmapsupp from MapSource but not about the one from mkgmap. I think that shows that unpatched MdrCheck is wrong.

I tried this also with a binary from r4817 with attached mkgmap-no-secondary-v2.patch with your command.
The two outputs from MdrCheck are identical, and I think the outputs for MdrDisplay differ only in offsets. I consider this very good.
In MapSource the search for "Baybride Lane" and "Alma Lane" both return wherWell, so that's also good.

I prefer a patch that changes mkgmap to produce the same index as MapSource.

I hope I've done nothing wrong during testing. Do you get other results?

Gerd

________________________________________
Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag von Ticker Berkin <rwb-mkgmap at jagit.co.uk>
Gesendet: Freitag, 26. November 2021 16:27
An: Development list for mkgmap
Betreff: Re: [mkgmap-dev] Small problem with global index

Hi Gerd

I was sort of thinking the opposite. PlaceFile using some method (eg
what it does) to dedupe city/region/country and this is extended to the
POI/MDRBuilder logic, such that combinations of these 3 have unique
sets of index values regardless of case.

Then the relevant MdrX sections should be able to do a SECONDARY dedup
on these, to cope with case-variants coming from different tiles.

Then checking that this does actually work with Garmin software (ie
hope nothing cares that the index entries might not match the LBL data
in some of the tiles)

If this works, there should only be one city presented in the find
options - eg, from the original problem data, it might be "De Wijk" or
"de Wijk"

Then making MdrCheck tolerant of this as well.

An alternative is just to ignore the whole issue - no one else has ever
noticed and complained.

I was hoping to get mdrUnicode_v9b.patch accepted before tackling this.
Its purpose is to fix the crash when pathological city / region /
country names or incomplete sortorder codepage data causes enough
difference between TERTIARY & EQUAL to make Mdr25 index size too big.

Ticker

On Fri, 2021-11-26 at 10:56 +0000, Gerd Petermann wrote:
> Hi Ticker,
>
> reg. --lower-case and city/region/country names with different
> capitalization:
> I think it would be good to keep the different capitalization within
> a single tile, so yes, the .toUpperCase() in PlacesFile is probably
> not a good idea. Results seem better when this is not done.
> When the global index is created we can log warnings for those cases,
> but I don't see yet how we can create a valid index which doesn't
> require the user to decide whether wherWell or Wherwell should be
> searched.
>
> Gerd

_______________________________________________
mkgmap-dev mailing list
mkgmap-dev at lists.mkgmap.org.uk
https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mkgmap-no-secondary-v2.patch
Type: application/octet-stream
Size: 6162 bytes
Desc: mkgmap-no-secondary-v2.patch
URL: <http://www.mkgmap.org.uk/pipermail/mkgmap-dev/attachments/20211126/791e9cc7/attachment.obj>