[mkgmap-dev] r4836 stops Hungary & Romania

Thu Dec 30 15:26:31 GMT 2021

Hi Ticker,

please check. Your patch contains U+200B        "ZERO WIDTH SPACE" characters which confuse my Eclipse installation.
You probably created them while experimenting with the surrogates?

I'll commit the modified patch.

Gerd

________________________________________
Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag von Ticker Berkin <rwb-mkgmap at jagit.co.uk>
Gesendet: Donnerstag, 30. Dezember 2021 14:53
An: Development list for mkgmap
Betreff: Re: [mkgmap-dev] r4836 stops Hungary & Romania

Hi Gerd

Patch attached that handles UTF16 surrogate pairs so that mkgmap style
filters substring and highway-shield give correct results, the LBL
trimming leaves the correct amount and neither end up with 1/2 a
character.

I've looked through all the substring operations and I don't think any
others will cause problems. There might just be a few str.length() and
str.charAt() or other indexing that might need attention but this would
require a lot more searching. I've left the handling for
MALFORMED_INPUT so these shouldn't matter.

Ticker

On Wed, 2021-12-29 at 09:16 +0000, Ticker Berkin wrote:
> Hi Gerd
>
> I'll look at this sometime. I while ago I found something in one of
> the
> MDR sections (probably the short strings) that handled something like
> this.
>
> Ticker
>
>
> On Tue, 2021-12-28 at 13:22 +0000, Gerd Petermann wrote:
> > Hi Ticker,
> >
> > okay, maybe you find time to implement a better solution.
> > I've committed the patch with r4838.
> >
> > @Arndt: Please check if this solves the problems with your maps.
> > Not sure about this because you said mkgmap stops without any
> > reaction
> > while this problem was a loop.
> >
> > Gerd
>
>
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-dev at lists.mkgmap.org.uk
> https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev