[mkgmap-dev] [PATCH v2] - styling for the power user

Sun Aug 9 10:24:24 BST 2009

Mark Burton wrote:
> v2
>
> now supports ~[0x??] syntax within name to specify highway shields
>
> to reduce the number of tags required, you can now specify all the
> values in the mkgmap:gtype tag like this example:
>
> mkgmap:gtype="0x20,19,,1,2"
>
> type = 0x20
> minres = 19
> maxres not specified
> roadclass = 1
> roadspeed = 2
>
> The one tag per value scheme is still supported (for the moment at
> least)
>   

I tested this patch today, and it worked as advertised. Thanks for your 
work.

I have a suggestion.

Would it be better to use
<tag k="mkgmap:gtype" v="0x06,21,,1,2"/>
instead of
<tag k="mkgmap:gtype=0x06,21,,1,2"/>

I know nothing about osm format, other that what I observed, but the 
latter syntax looks the more obvious to me. If you try this (as I did 
until in my first try), you will get a NullPointerException.

I think the long format , with seperate tags, is redundant. It's most 
likely that people using this syntax will be using a preprocessor of 
some kind, and I doubt if many preprocessors were written between 
version 1 and version 2 of your patch.

Thanks

Garvan