[mkgmap-dev] [PATCH v2] - styling for the power user

Sun Aug 9 16:46:03 BST 2009

Hi Garvan,

Thanks for the feedback.

> I tested this patch today, and it worked as advertised. Thanks for your 
> work.

Good.

> I have a suggestion.
> 
> Would it be better to use
> <tag k="mkgmap:gtype" v="0x06,21,,1,2"/>
> instead of
> <tag k="mkgmap:gtype=0x06,21,,1,2"/>
> 
> I know nothing about osm format, other that what I observed, but the 
> latter syntax looks the more obvious to me. If you try this (as I did 
> until in my first try), you will get a NullPointerException.

Yes, the first syntax is correct, my blurb used the wrong syntax.

> I think the long format , with seperate tags, is redundant. It's most 
> likely that people using this syntax will be using a preprocessor of 
> some kind, and I doubt if many preprocessors were written between 
> version 1 and version 2 of your patch.

I agree, I have now issued v3 which now only has the one tag
'mkgmap:gtype'. The kind (node, line, area) is now specified as the
first value in the list.

Cheers,

Mark