[mkgmap-dev] [PATCH] Allow ~ and friends at top level

Sun Jan 17 10:20:03 GMT 2010

Hi Felix,

Thank you for testing my patch.  In any case, I will try to figure out
what caused the size difference for me.  Even if the patch does not seem
to bring much CPU-wise, the compact notation could be useful in some cases.
But as your example shows, the downside of the compactness would be extra
care needed when editing rules:

On Sun, Jan 17, 2010 at 12:18:07AM +0100, Felix Hartmann wrote:
> I lost all of the following
> new:
> place ~ 'town\|suburb\village' [0x03 resolution 21]
> old:
> place=suburb | place=town | place=village [0x03 resolution 21]

It should be suburb\|village, not suburb\village.  You should have got
points for place=town, but there probably were no place="suburb\village"
in the input. :-) (I don't even know what the \v would translate into
in this case.  Probably just 'v', but it could be 0x0b (vertical tab) too.

> Your testing could well be different because you were putting two lines  
> into one like
> key1=123
> key1=456
>
> whereas I changed from
> key1=123 | key1=456

I don't know if this really makes a difference.  A comment in the method
that I changed suggested that the top-level | would be split earlier.
It could very well be equivalent to writing separate rules for each
top-level | operand.

Best regards,

	Marko