logo separator

[mkgmap-dev] [PATCH v2] finalizer style file

From WanMil wmgcnfg at web.de on Fri Nov 1 19:30:44 GMT 2013

The finalizer rules are now defined in each style file.

The rules start after the finalize section marker:
<finalize>

@Steve: Please have a look on the patch. I think it is cleanly 
integrated in the current implementation without too much hacking ;-) I 
haven't implemented tests yet so it's not well tested. But my first 
tests seemed to work well.

WanMil


> Hi WanMil
>
>> I had a look how much effort it is to add a finalizer style file that is
>> used each time a rule with an element type definition matches. This
>> might make it more easy to implement "general rules" (like the
>> mkgmap:access tag which seems to be useful for complex styles). The
>> finalize file must contain actions only. Otherwise mkgmap stops with an
>> error message.
>
> This is interesting, early on I though that access rules would have
> to be in a separate file and this might be it.
>
> It also fits in with something else that I want to do, which is
> to remove all the other getTag() calls from StyledConverter.
>
>> @Steve: do you think it would be possible to add a finalize section to
>> the bottom of each style file (especially points, lines and polygons)? I
>> have the feeling that this is more understandable and maybe better to
>> have different finalize styles for each element type.
>
> Sounds like a good idea, I can't think of a syntax for it I like just
> yet though.  You could also have different files lines_final,
> points_final etc.
>
> ..Steve

-------------- next part --------------
A non-text attachment was scrubbed...
Name: finalizer_style_v2.patch
Type: text/x-patch
Size: 15129 bytes
Desc: not available
URL: <http://lists.mkgmap.org.uk/pipermail/mkgmap-dev/attachments/20131101/dd4a8e46/attachment.bin>


More information about the mkgmap-dev mailing list