[mkgmap-dev] [PATCH v2] finalizer style file

Sun Nov 3 11:50:30 GMT 2013

Attached is another patch introducing the new finalize part.
Now a test is included and rules with actions that have an element type 
definition are now also handled by the finalize block.

I think it is now ready to commit (for branch and trunk).
(I don't yet understand why a scripted style test didn't work....).

WanMil

> The finalizer rules are now defined in each style file.
>
> The rules start after the finalize section marker:
> <finalize>
>
> @Steve: Please have a look on the patch. I think it is cleanly
> integrated in the current implementation without too much hacking ;-) I
> haven't implemented tests yet so it's not well tested. But my first
> tests seemed to work well.
>
> WanMil
>
>
>> Hi WanMil
>>
>>> I had a look how much effort it is to add a finalizer style file that is
>>> used each time a rule with an element type definition matches. This
>>> might make it more easy to implement "general rules" (like the
>>> mkgmap:access tag which seems to be useful for complex styles). The
>>> finalize file must contain actions only. Otherwise mkgmap stops with an
>>> error message.
>>
>> This is interesting, early on I though that access rules would have
>> to be in a separate file and this might be it.
>>
>> It also fits in with something else that I want to do, which is
>> to remove all the other getTag() calls from StyledConverter.
>>
>>> @Steve: do you think it would be possible to add a finalize section to
>>> the bottom of each style file (especially points, lines and polygons)? I
>>> have the feeling that this is more understandable and maybe better to
>>> have different finalize styles for each element type.
>>
>> Sounds like a good idea, I can't think of a syntax for it I like just
>> yet though.  You could also have different files lines_final,
>> points_final etc.
>>
>> ..Steve
>
>
>
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-dev at lists.mkgmap.org.uk
> http://lists.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: finalizer_style_v3.patch
Type: text/x-patch
Size: 21978 bytes
Desc: not available
URL: <http://lists.mkgmap.org.uk/pipermail/mkgmap-dev/attachments/20131103/f416b9de/attachment-0001.bin>