[mkgmap-dev] echo improvements for elements with fake ids

Wed Jan 21 21:10:27 GMT 2015

Hi WanMil,

good catch. I only looked at the normal processing.
Reg. memory:
I think one additional String instance  + 
In some cases the additional tag will increase the
tag arrays, hard to say how often that will happen.

Gerd

WanMil wrote
> Hi Gerd,
> 
> did you measure the impact on the BoundaryPreprocessor and the 
> PrecompiledSeaGenerator?
> I guess they might load much more than 500k instances and I think it 
> would be ok to disable the original id tracking when they are running.
> 
> On the other hand can you roughly estimate the size of an additional 
> tag? Is it the additional String instance?
> 
> I am thinking how to fix the thing that the original id might be derived 
> from a different element type. A tag would be easy to implement without 
> big impacts.
> 
> WanMil
> 
>> Hi Mike,
>>
>> I've committed the patch as is. The memory impact is not that big as
>> we have typically less than 500.000 instances of Element in one tile,
>> so 8 more bytes * 500.000  ~ 4MB more heap.
>>
>> Gerd
>>
>> From: 

> mike at .co

>> To: 

> mkgmap-dev at .org

>> Date: Mon, 19 Jan 2015 11:55:00 +0000
>> Subject: [mkgmap-dev] echo improvements for elements with fake ids
>>
>> The attached patch improves the echo and echotags messages by including
>> the
>> id of the original element when a fake id is generated by mkgmap, thus
>> enabling you to find it in OSM.
>>
>> Please try, and commit if you are happy with the change.
>>
>> Regards,
>> Mike
>>
>>
>> _______________________________________________ mkgmap-dev mailing list
>> 

> mkgmap-dev at .org

>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
>>
>>
>> _______________________________________________
>> mkgmap-dev mailing list
>> 

> mkgmap-dev at .org

>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
>>
> 
> _______________________________________________
> mkgmap-dev mailing list

> mkgmap-dev at .org

> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

--
View this message in context: http://gis.19327.n5.nabble.com/echo-improvements-for-elements-with-fake-ids-tp5830557p5830880.html
Sent from the Mkgmap Development mailing list archive at Nabble.com.