[mkgmap-dev] echo improvements for elements with fake ids

Thu Jan 22 08:22:38 GMT 2015

Hi WanMil,

probably no problem here.
My results:
PrecompiledSeaGenerator: no significant effect
BoundaryPreprocessor : very small effect. 
I think in both cases the Element instances are not kept for long,
means, they are converted into something else 
which is not based on Element. The number of Element instances
is not very high compared to Coord instances and / or the
doubles used in java areas.

Gerd

> Date: Wed, 21 Jan 2015 21:16:54 +0100
> From: wmgcnfg at web.de
> To: mkgmap-dev at lists.mkgmap.org.uk
> Subject: Re: [mkgmap-dev] echo improvements for elements with fake ids
> 
> Hi Gerd,
> 
> did you measure the impact on the BoundaryPreprocessor and the 
> PrecompiledSeaGenerator?
> I guess they might load much more than 500k instances and I think it 
> would be ok to disable the original id tracking when they are running.
> 
> On the other hand can you roughly estimate the size of an additional 
> tag? Is it the additional String instance?
> 
> I am thinking how to fix the thing that the original id might be derived 
> from a different element type. A tag would be easy to implement without 
> big impacts.
> 
> WanMil
> 
> > Hi Mike,
> >
> > I've committed the patch as is. The memory impact is not that big as
> > we have typically less than 500.000 instances of Element in one tile,
> > so 8 more bytes * 500.000  ~ 4MB more heap.
> >
> > Gerd
> >
> > From: mike at tvage.co.uk
> > To: mkgmap-dev at lists.mkgmap.org.uk
> > Date: Mon, 19 Jan 2015 11:55:00 +0000
> > Subject: [mkgmap-dev] echo improvements for elements with fake ids
> >
> > The attached patch improves the echo and echotags messages by including the
> > id of the original element when a fake id is generated by mkgmap, thus
> > enabling you to find it in OSM.
> >
> > Please try, and commit if you are happy with the change.
> >
> > Regards,
> > Mike
> >
> >
> > _______________________________________________ mkgmap-dev mailing list
> > mkgmap-dev at lists.mkgmap.org.uk
> > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> >
> >
> > _______________________________________________
> > mkgmap-dev mailing list
> > mkgmap-dev at lists.mkgmap.org.uk
> > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> >
> 
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-dev at lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mkgmap.org.uk/pipermail/mkgmap-dev/attachments/20150122/ac0f856e/attachment.html>