[mkgmap-dev] patch for crash in MapSource

Fri Feb 9 08:56:54 GMT 2018

Hi Nick,

I use max-nodes=100 000, not 10 000, but you may be right that this is important.
I'll try again with realistic values.

Gerd

________________________________________
Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag von osm at pinns <osm at pinns.co.uk>
Gesendet: Freitag, 9. Februar 2018 09:38
An: mkgmap-dev at lists.mkgmap.org.uk
Betreff: Re: [mkgmap-dev] patch for crash in MapSource

Hi Gerd

I'm getting the same issues when I split Devon with max nodes 10 000

in fact anything below 40 000 causes a crash

The tests I made yesterday  was with max nodes 80 000, so perhaps
somehow its linked to the maxnodes?

r

Nick

On 09/02/2018 08:01, Gerd Petermann wrote:
> Hi Nick,
>
> I tried --align-for-dem=360 with your --dem-dists=2484,3312,9942,16560 and my dem-poly
> and it always crashes :-(
>
> It always seems to work with only one of the values, e.g. --dem-dists=2484 or --dem-dists=3312 or --dem-dists=16560
>
> So, it seems that I was wrong when I thought that the code behind the "Show Profile..." button would ignore all but the highest
> resolution.
>
> Gerd
>
> ________________________________________
> Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag von osm at pinns <osm at pinns.co.uk>
> Gesendet: Donnerstag, 8. Februar 2018 22:19
> An: mkgmap-dev at lists.mkgmap.org.uk
> Betreff: Re: [mkgmap-dev] patch for crash in MapSource
>
> Hi Gerd
>
> Just noticed your crash.gdb , which indeed causes a crash
>
> However, if I take a different starting point  but still join the a39
> where your route joins it , I don't get a crash,
>
> Very odd that the end sames ok but the beginning.
>
> Anyway, will do some more checking tomorrow
>
> Nick
> On 08/02/2018 21:04, osm at pinns wrote:
>> Hi Gerd
>>
>> I can see that , but again no probs here when I used your map
>>
>> For my final trial i used some pbf files of the UK which were split
>> last year without the align for dem option
>>
>> This still worked !, ie no crashes ;
>>
>> good point - have to check if the dem poly includes empty hgt files.
>>
>> Will do some more checking tomorrow.
>>
>> Again, congratulations on a major achievement!
>>
>> Nick
>>
>>
>> On 08/02/2018 20:36, Gerd Petermann wrote:
>>> Hi Nick,
>>>
>>> okay, sounds good. Do you also use -dem-poly or hgt files with voids?
>>> I tested a rather small polygon [1] divided into 10 parts, maybe that
>>> created more stress
>>> for MapSource.
>>>
>>> Maybe we can find other --align-for-dem values or -even better -
>>> a field in TRE or DEM  or TDB that can be changed to allow more or
>>> all values.
>>>
>>> Gerd
>>>
>>> [1] http://files.mkgmap.org.uk/download/412/baddem6b.7z
>>>
>>> ________________________________________
>>> Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag
>>> von osm at pinns <osm at pinns.co.uk>
>>> Gesendet: Donnerstag, 8. Februar 2018 21:22
>>> An: mkgmap-dev at lists.mkgmap.org.uk
>>> Betreff: Re: [mkgmap-dev] patch for crash in MapSource
>>>
>>> Hi Gerd,
>>>
>>> Having difficulty creating long distances without stopovers ikn
>>> Mapsource, but that seems have been the case anyway before dem, at least
>>> in my case using default style
>>>
>>> Have created a long distance one in Basecamp, exported it in Mapsource
>>> and absolutely no problem with creating profiles! Excellent work !
>>>
>>> If I invert the route , ie in Basecamp, and export it in mapsource, same
>>> : no issues at all
>>>
>>> At one stage, I cannot reproduce it ,I just got a black profile, but
>>> that could be when I a dem was missing.
>>>
>>>
>>> On 08/02/2018 19:11, Gerd Petermann wrote:
>>>> Hi Nick,
>>>>
>>>> great! In my test cases I found problems with long distance routes
>>>> without any stopover.
>>>> Please try that as well, maybe also the inverse routes.
>>>>
>>>> Gerd
>>>>
>>>> ________________________________________
>>>> Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag
>>>> von osm at pinns <osm at pinns.co.uk>
>>>> Gesendet: Donnerstag, 8. Februar 2018 19:01
>>>> An: mkgmap-dev at lists.mkgmap.org.uk
>>>> Betreff: Re: [mkgmap-dev] patch for crash in MapSource
>>>>
>>>> Hi Gerd
>>>>
>>>> Brilliant ! have done a really spaghetti route with lots of ups and
>>>> downs left and right and
>>>>
>>>> seems to be working with align-for-dem=360  and even
>>>>
>>>> --dem-dists=2484,3312,9942,16560
>>>>
>>>> r
>>>>
>>>> Nick
>>>>
>>>> On 08/02/2018 17:40, Gerd Petermann wrote:
>>>>
>>>> Hi all,
>>>>
>>>> I've created patches for splitter and mkgmap.
>>>> The binaries are here:
>>>>     http://files.mkgmap.org.uk/download/417/splitter.jar
>>>> http://files.mkgmap.org.uk/detail/416
>>>>
>>>> Please try splitter with align-for-dem=360. I found no more crashes
>>>> as long
>>>> as used only one dem level, e.g. dem-dists=3312 or dem-dists=9936
>>>>
>>>> Maybe you find a combination of  align-for-dem and dem-dists with
>>>> more than one value
>>>> that still works, I'll try again tomorrow.
>>>>
>>>> Gerd
>>>>
>>>> ________________________________________
>>>> Von: mkgmap-dev
>>>> <mkgmap-dev-bounces at lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces at lists.mkgmap.org.uk>
>>>> im Auftrag von Gerd Petermann
>>>> <gpetermann_muenchen at hotmail.com><mailto:gpetermann_muenchen at hotmail.com>
>>>> Gesendet: Donnerstag, 8. Februar 2018 13:16
>>>> An: Development list for mkgmap
>>>> Betreff: Re: [mkgmap-dev] patch for crash in MapSource
>>>>
>>>> Hi all,
>>>>
>>>> the patch contained a stupid bug, but there is more to this:
>>>> 1) the effect of the patch depends on the dem-dists value (I assume
>>>> only the one
>>>> that gives the highest resolution). The higher the resolution the
>>>> better it works.
>>>> 2) it probably also depends on the boundaries (areas.list)
>>>>
>>>> I assume now that the tile boundary from areas.list should be a
>>>> certain multiples of degrees,
>>>> probably different multiples for lat and lon and that the overlap
>>>> simply makes
>>>> sure that this boundary is within the overlapped area.
>>>> Maybe the preferred multiples also depend on the dem-dist.
>>>>
>>>> I'll try to find out more ...
>>>>
>>>> Gerd
>>>>
>>>> ________________________________________
>>>> Von: mkgmap-dev
>>>> <mkgmap-dev-bounces at lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces at lists.mkgmap.org.uk>
>>>> im Auftrag von osm at pinns <osm at pinns.co.uk><mailto:osm at pinns.co.uk>
>>>> Gesendet: Donnerstag, 8. Februar 2018 10:33
>>>> An:
>>>> mkgmap-dev at lists.mkgmap.org.uk<mailto:mkgmap-dev at lists.mkgmap.org.uk>
>>>> Betreff: Re: [mkgmap-dev] patch for crash in MapSource
>>>>
>>>> Hi Gerd
>>>>
>>>> I think you are right ,ie
>>>>
>>>> start and finishing point  at same level seems OK eventhough the route
>>>> turns south 20miles then up again
>>>>
>>>> r
>>>>
>>>> Nick
>>>>
>>>>
>>>> On 08/02/2018 09:27, Gerd Petermann wrote:
>>>>
>>>>
>>>> Hi all,
>>>>
>>>> okay, thanks for testing. I'll try to find a better patch.
>>>> Please check: I think the patch works fine for routes which cross
>>>> tile borders in horizontal direction
>>>> direction but I still see problems with vertical crossing. Can you
>>>> confirm that?
>>>>
>>>> Gerd
>>>>
>>>> ________________________________________
>>>> Von: mkgmap-dev
>>>> <mkgmap-dev-bounces at lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces at lists.mkgmap.org.uk>
>>>> im Auftrag von Henning Scholland
>>>> <osm at hscholland.de><mailto:osm at hscholland.de>
>>>> Gesendet: Donnerstag, 8. Februar 2018 09:59
>>>> An: Development list for mkgmap
>>>> Betreff: Re: [mkgmap-dev] patch for crash in MapSource
>>>>
>>>> Same for me, but just did quick test. Will try on the weekend more
>>>> detailed
>>>> Henning
>>>> On 8 Feb 2018, at 16:57, lig fietser
>>>> <ligfietser at hotmail.com<mailto:ligfietser at hotmail.com><mailto:ligfietser at hotmail.com><mailto:ligfietser at hotmail.com>>
>>>> wrote:
>>>>
>>>> Hi Gerd,
>>>>
>>>> I tested your patch but I still see frequent crashes near tile borders.
>>>>
>>>>
>>>> ________________________________
>>>> Van: mkgmap-dev
>>>> <mkgmap-dev-bounces at lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces at lists.mkgmap.org.uk>
>>>> namens Gerd Petermann
>>>> <GPetermann_muenchen at hotmail.com><mailto:GPetermann_muenchen at hotmail.com>
>>>> Verzonden: woensdag 7 februari 2018 02:45:27
>>>> Aan:
>>>> mkgmap-dev at lists.mkgmap.org.uk<mailto:mkgmap-dev at lists.mkgmap.org.uk>
>>>> Onderwerp: [mkgmap-dev] patch for crash in MapSource
>>>>
>>>> Hi all,
>>>>
>>>> attached is a patch that seems to help in many cases where
>>>> --dem-poly causes crashes in MapSource "Show Profile..."
>>>> A binary is here:
>>>> http://files.mkgmap.org.uk/download/414/mkgmap.jar
>>>>
>>>> It changes the TRE file and the *.tdb file.
>>>> I still see a few crashes but maybe those are caused by other problems.
>>>>
>>>> Please try and let me know your results. I found no bad impact so far,
>>>> long distance routing still seems to work, but I've not tested much.
>>>>
>>>> @Steve: Maybe we have to make sure that the areas in *.tdb do not
>>>> overlap.
>>>> In this case this patch is not yet okay.
>>>>
>>>> Gerd
>>>>
>>>> ________________________________
>>>>
>>>> mkgmap-dev mailing list
>>>> mkgmap-dev at lists.mkgmap.org.uk<mailto:mkgmap-dev at lists.mkgmap.org.uk>
>>>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
>>>> _______________________________________________
>>>> mkgmap-dev mailing list
>>>> mkgmap-dev at lists.mkgmap.org.uk<mailto:mkgmap-dev at lists.mkgmap.org.uk>
>>>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> mkgmap-dev mailing list
>>>> mkgmap-dev at lists.mkgmap.org.uk<mailto:mkgmap-dev at lists.mkgmap.org.uk>
>>>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
>>>> _______________________________________________
>>>> mkgmap-dev mailing list
>>>> mkgmap-dev at lists.mkgmap.org.uk<mailto:mkgmap-dev at lists.mkgmap.org.uk>
>>>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
>>>>
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> mkgmap-dev mailing list
>>>> mkgmap-dev at lists.mkgmap.org.uk<mailto:mkgmap-dev at lists.mkgmap.org.uk>
>>>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
>>>>
>>>> _______________________________________________
>>>> mkgmap-dev mailing list
>>>> mkgmap-dev at lists.mkgmap.org.uk
>>>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
>>> _______________________________________________
>>> mkgmap-dev mailing list
>>> mkgmap-dev at lists.mkgmap.org.uk
>>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
>> _______________________________________________
>> mkgmap-dev mailing list
>> mkgmap-dev at lists.mkgmap.org.uk
>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-dev at lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-dev at lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

_______________________________________________
mkgmap-dev mailing list
mkgmap-dev at lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev