[mkgmap-dev] Problem in AngleFixer?

Thu Aug 29 09:42:32 BST 2024

Hi

I've improved some of the logic where arcs on either side of an angle are one-
way (merging, splitting or continuous).

I didn't detect turn-left/right instructions rather then keep-left/right on the
roads I use where there is a gradual split. However I thought this would be a
possibility in other cases if the angles on the split were increased so it
seemed best give an accurate representation to the device and let it announce
what it considers best.

One-ways merging don't need any increase in angle.

Continuous one-ways were considered to be a flare, eg joining a roundabout or a
more major road and the angle wasn't increased, but there are other cases where
it should be, so I've removed this as a special case.

Patch attached

Ticker

On Mon, 2024-08-26 at 17:16 +0100, Ticker Berkin wrote:
> Hi Gerd & Thorsten
> 
> I need to test one more scenario where a fast one-way lane splits with equal
> priority (eg on a motorway) and check that my changes don't trigger a turn
> instruction instead of "keep-left" or "keep-right".
> 
> Please don't commit anything until I've tested this.
> 
> Ticker
> 
> On Mon, 2024-08-26 at 11:55 +0000, Gerd Petermann wrote:
> > Hi Ticker,
> > 
> > the patch solves the original problem at https://www.osm.org/node/27550903
> > I tried to find other places where the change in the map data produce
> > differences in routing but without success so far.
> > I think that's good news, but all cases only involved footways or tracks so
> > far.
> > 
> > So, I wait for Thorsten to confirm that the patch is an improvement.
> > 
> > Gerd
> > 
> > 
> > 
> > ________________________________________
> > Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag von
> > Ticker
> > Berkin <rwb-mkgmap at jagit.co.uk>
> > Gesendet: Samstag, 24. August 2024 18:30
> > An: Development list for mkgmap
> > Betreff: Re: [mkgmap-dev] Problem in AngleFixer?
> > 
> > Hi Gerd & Thorsten
> > 
> > This, I hope, is the final version of the changes to AngleFixer.
> > 
> > I've simplified and clarified some of the logic, improved some of the
> > diagnostics, added more comments and made better choices of when compactDir
> > format is used. There should be a slight reduction in .img size, fewer time
> > penalties and better turn-instructions.
> > 
> > Regards
> > Ticker
> > _______________________________________________
> > mkgmap-dev mailing list
> > mkgmap-dev at lists.mkgmap.org.uk
> > https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> 
> 
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-dev at lists.mkgmap.org.uk
> https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

-------------- next part --------------
A non-text attachment was scrubbed...
Name: AngleChecker_v6.patch
Type: text/x-patch
Size: 20791 bytes
Desc: not available
URL: <https://www.mkgmap.org.uk/pipermail/mkgmap-dev/attachments/20240829/fe771ead/attachment-0001.bin>