[mkgmap-dev] Problem in AngleFixer?

Fri Aug 30 08:59:08 BST 2024

Hi,

I tested that patch in BaseCamp and yesterday evening on a bicycle tour. 
Navigation instructions were good, I haven't seen any wrong hint, no 
missing one and also no superfluous. Same result as I had already on 
several other tours the last days with v5.
Great job, that patch is a big improvement!

With v6 I had some wired navigation instructions on one place when when 
I deviated from the route and it automatically guided me back. But when 
I did inspect the map today, there is a small, parallel path, could be 
very well that the Garmin device wanted to route me via that way and it 
was not visible on the small display.
I couldn't reproduce that with a GPX track or BaseCamp. Need to check 
the OSM data later, I assume wrong tags.
Or I need to switch the line types in my maps. It's really wired which 
effect line types have on routing and navigation instructions.
So if you get flooded with useless navigation instructions, this could 
also be the fault of using the wrong line type in your map...

Thorsten

Am 2024-08-29 10:42, schrieb Ticker Berkin:
> Hi
> 
> I've improved some of the logic where arcs on either side of an angle 
> are one-
> way (merging, splitting or continuous).
> 
> I didn't detect turn-left/right instructions rather then 
> keep-left/right on the
> roads I use where there is a gradual split. However I thought this 
> would be a
> possibility in other cases if the angles on the split were increased so 
> it
> seemed best give an accurate representation to the device and let it 
> announce
> what it considers best.
> 
> One-ways merging don't need any increase in angle.
> 
> Continuous one-ways were considered to be a flare, eg joining a 
> roundabout or a
> more major road and the angle wasn't increased, but there are other 
> cases where
> it should be, so I've removed this as a special case.
> 
> Patch attached
> 
> Ticker
> 
> On Mon, 2024-08-26 at 17:16 +0100, Ticker Berkin wrote:
>> Hi Gerd & Thorsten
>> 
>> I need to test one more scenario where a fast one-way lane splits with 
>> equal
>> priority (eg on a motorway) and check that my changes don't trigger a 
>> turn
>> instruction instead of "keep-left" or "keep-right".
>> 
>> Please don't commit anything until I've tested this.
>> 
>> Ticker
>> 
>> On Mon, 2024-08-26 at 11:55 +0000, Gerd Petermann wrote:
>> > Hi Ticker,
>> >
>> > the patch solves the original problem at https://www.osm.org/node/27550903
>> > I tried to find other places where the change in the map data produce
>> > differences in routing but without success so far.
>> > I think that's good news, but all cases only involved footways or tracks so
>> > far.
>> >
>> > So, I wait for Thorsten to confirm that the patch is an improvement.
>> >
>> > Gerd
>> >
>> >
>> >
>> > ________________________________________
>> > Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag von
>> > Ticker
>> > Berkin <rwb-mkgmap at jagit.co.uk>
>> > Gesendet: Samstag, 24. August 2024 18:30
>> > An: Development list for mkgmap
>> > Betreff: Re: [mkgmap-dev] Problem in AngleFixer?
>> >
>> > Hi Gerd & Thorsten
>> >
>> > This, I hope, is the final version of the changes to AngleFixer.
>> >
>> > I've simplified and clarified some of the logic, improved some of the
>> > diagnostics, added more comments and made better choices of when compactDir
>> > format is used. There should be a slight reduction in .img size, fewer time
>> > penalties and better turn-instructions.
>> >
>> > Regards
>> > Ticker
>> > _______________________________________________
>> > mkgmap-dev mailing list
>> > mkgmap-dev at lists.mkgmap.org.uk
>> > https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
>> 
>> 
>> _______________________________________________
>> mkgmap-dev mailing list
>> mkgmap-dev at lists.mkgmap.org.uk
>> https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> 
> 
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-dev at lists.mkgmap.org.uk
> https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev